-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue240 2 #256
Issue240 2 #256
Conversation
+ Added a fake closed property to override parent + Overiding filno with the underlying standard no + Rename the class for better coherence with the concept
+ added a plugin to test that redirection really occured + removed debugging code
+ Code cleanup
+ enhanced the runner + enhanced skip msg when used with full verbosity
+ Also added fake close method and property logic for getting buffer because of results of tests
- renamed the plugin
when I try it locally:
It looks like it is using the wrong python version in one script... |
yeah, forgot that in flow setup, this should be working for that now. But on the side of Travis I don't know what is happening but this isn't going well... |
Ok Don't merge that... sarra download is broken... will investigate that tomorrow |
This reverts commit e09635e.
Still got major defects, not passing the flow test. I will need to investigate a little more... |
#240. I completed that feature, I added unit test while converting sr_config unit test to unittest framework and also integrated it to flow test.
Unfortunately, I just realised that I didn't automated the fondamental test of this case which is the launch with ssh, but I did it manually with hpfx_amis subcriber. If we want an automated test for that, I think it would make sense to add it to the test suite